Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues:
Resolves #PQCrypto-120
Description of changes:
This PR updates the fuzz tests to include seeds based upon ML-DSA private key encodings. I provided manual seeds to the corpus to fuzz specifically against private key import.
Seed1: ML-DSA-44 private key:
Seed2 ML-DSA-65 private key:
Seed1: ML-DSA-87 private key:
Methodology:
./fuzz/pkcs8 -max_len=2048 -jobs=32 -workers=32 mldsa-seed/
./fuzz/pkcs8 -merge=1 min-corpus/ mldsa-seed/
./fuzz/pkcs8 -merge=1 merged/ min-corpus/ ../fuzz/pkcs8_corpus/
As an example, the new file
2aedfe1f6ee6e99c5947577cc6d59a9611f2a085
contains the fuzz clearly generated from the ML-DSA seeded BASE64 encoding:Call-outs:
Wasn't able to get a coverage report from https://github.com/aws/aws-lc/blob/main/docs/Coverage.md as
lcov
didn't want to play withclang
.We were at
231
fuzz vectors inpkcs8_corpus
and now we are at333
.Testing:
Testing coverage was tested by introducing an error (emulated #2152). These tests caught the error.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.