Add SSL_CTX_use_cert_and_key #2163
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2163 +/- ##
==========================================
+ Coverage 79.05% 79.07% +0.01%
==========================================
Files 612 612
Lines 106218 106403 +185
Branches 15006 15035 +29
==========================================
+ Hits 83970 84137 +167
- Misses 21595 21615 +20
+ Partials 653 651 -2 ☔ View full report in Codecov by Sentry. |
justsmth
reviewed
Feb 13, 2025
justsmth
reviewed
Feb 18, 2025
justsmth
previously approved these changes
Feb 20, 2025
justsmth
previously approved these changes
Feb 24, 2025
justsmth
previously approved these changes
Feb 24, 2025
skmcgrail
reviewed
Feb 24, 2025
skmcgrail
approved these changes
Feb 25, 2025
justsmth
approved these changes
Feb 25, 2025
smittals2
added a commit
to smittals2/aws-lc
that referenced
this pull request
Mar 26, 2025
`CryptoAlg-2863` Adds the function SSL_CTX_use_cert_and_key which sets the leaf, chain, and private key all in one operation. This function is also needed by librdkafka. Regenerated error data Point out areas that need special attention or support during the review process. Discuss architecture or design changes. Tests using this API to set the relevant fields and ensure TLS connection succeeds. By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license. --------- Co-authored-by: Justin W Smith <[email protected]> Co-authored-by: Justin Smith <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues:
CryptoAlg-2863Description of changes:
Adds the function SSL_CTX_use_cert_and_key which sets the leaf, chain, and private key all in one operation. This function is also needed by librdkafka.
Call-outs:
Point out areas that need special attention or support during the review process. Discuss architecture or design changes.
Testing:
Tests using this API to set the relevant fields and ensure TLS connection succeeds.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.