Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SSL_CTX_use_cert_and_key #2163

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Conversation

smittals2
Copy link
Contributor

Issues:

CryptoAlg-2863

Description of changes:

Adds the function SSL_CTX_use_cert_and_key which sets the leaf, chain, and private key all in one operation. This function is also needed by librdkafka.

Call-outs:

Point out areas that need special attention or support during the review process. Discuss architecture or design changes.

Testing:

Tests using this API to set the relevant fields and ensure TLS connection succeeds.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@codecov-commenter
Copy link

codecov-commenter commented Feb 4, 2025

Codecov Report

Attention: Patch coverage is 85.48387% with 9 lines in your changes missing coverage. Please review.

Project coverage is 78.95%. Comparing base (695c3a0) to head (3ecfb98).
Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
ssl/ssl_cert.cc 79.54% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2163      +/-   ##
==========================================
- Coverage   78.96%   78.95%   -0.01%     
==========================================
  Files         611      611              
  Lines      105514   105610      +96     
  Branches    14941    14959      +18     
==========================================
+ Hits        83319    83389      +70     
- Misses      21543    21568      +25     
- Partials      652      653       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants