Add EVP API Support for ED25519ph #2144
Open
+550
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skmcgrail
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2144 +/- ##
==========================================
+ Coverage 78.97% 78.99% +0.01%
==========================================
Files 611 612 +1
Lines 105552 105744 +192
Branches 14951 14960 +9
==========================================
+ Hits 83356 83528 +172
- Misses 21542 21563 +21
+ Partials 654 653 -1 ☔ View full report in Codecov by Sentry. |
skmcgrail
changed the title
torben-hansen
previously approved these changes
Jan 30, 2025
nebeid
reviewed
Jan 31, 2025
skmcgrail
force-pushed
the
ed25519ph-hl
branch
from
54203b9 to
8a4c1c3
Compare
skmcgrail
force-pushed
the
ed25519ph-hl
branch
from
8a4c1c3 to
2399cc2
Compare
|
Reworked per our meeting to remove the keygen and ASN.1 serialization/deserialization support for ED25519ph. Should simplify the review some now. |
skmcgrail
force-pushed
the
ed25519ph-hl
branch
from
2399cc2 to
2b9bb6c
Compare
skmcgrail
force-pushed
the
ed25519ph-hl
branch
from
2b9bb6c to
d6d83f7
Compare
crypto/evp_extra/p_ed25519_asn1.c
Outdated
|
|
||
| const EVP_PKEY_ASN1_METHOD ed25519ph_asn1_meth = { | ||
| EVP_PKEY_ED25519PH, | ||
| {}, /* oid */ |
There was a problem hiding this comment.
Windows compilers doesn't seem to like this notation.
There was a problem hiding this comment.
Might explain why similar ASN.1 setups filled this in with a dummy value like {0xFF} even though the length is set to zero. Will give that a shot.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Add support for HashEdDSA (Ed25519ph) to EVP APIs with support for setting the associated signature context. Opting not to expose Ed25519ctx explicitly at this time since there hasn't been an ask for it. Worse case scenario a user desiring it will have access to the low-level APIs where it is available.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.