Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more test coverage for Ruby/OpenSSL gem #2085

Merged
merged 1 commit into from
Dec 31, 2024

Conversation

samuel40791765
Copy link
Contributor

Description of changes:

Follow up from #1563 (comment) where we add more test coverage for the Ruby/OpenSSL gem.

  • ruby_release_backport is for any commits that are already on the main branch and are required for some tests on older releases to pass through.
  • ruby_patch_common is for commits that all branches should need for additional tests to pass. These are outside of the ruby/openssl gem boundary, so I chose to consolidate the logic in a separate patch. Patches in this folder would be submitted to their respective repos instead of https://github.com/ruby/openssl.

Call-outs:

N/A

Testing:

CI

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@samuel40791765 samuel40791765 requested a review from a team as a code owner December 31, 2024 00:34
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.75%. Comparing base (39b3fae) to head (4ced8aa).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2085      +/-   ##
==========================================
- Coverage   78.75%   78.75%   -0.01%     
==========================================
  Files         598      598              
  Lines      103650   103650              
  Branches    14718    14718              
==========================================
- Hits        81633    81632       -1     
  Misses      21366    21366              
- Partials      651      652       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@samuel40791765 samuel40791765 merged commit 4243a79 into aws:main Dec 31, 2024
121 of 125 checks passed
@samuel40791765 samuel40791765 deleted the ruby-integration-more branch December 31, 2024 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants