aws-lc-fips-sys: Default to clang compiler #682
Closed
+10
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The underlying aws-lc library is broken when built with FIPS support on GCC-14, which comes by default with many Linux distributions. When this crate is used as a sub-dependency, the users' only workaround is to force all C/C++ code on other crates to also be compiled with clang by setting the CC/CXX environment variables. This change circumvents the issue by setting the CC/CXX environment variables in the crate build script. This is a temporary workaround until the underlying issue is resolved: aws/aws-lc#2010 Signed-off-by: Michel Heily <[email protected]>
justsmth
reviewed
Feb 3, 2025
|
Workaround (special env vars to affect compiler) merged in #678 , this is no longer needed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues:
Addresses #569
Description of changes:
The underlying aws-lc library is broken when built with FIPS support on GCC-14, which comes by default with many Linux distributions.
When this crate is used as a sub-dependency, the users' only workaround is to force all C/C++ code on other crates to also be compiled with clang by setting the CC/CXX environment variables.
This change circumvents the issue by setting the CC/CXX environment variables in the crate build script.
This is a temporary workaround until the underlying issue is resolved: aws/aws-lc#2010
Testing:
Tested the builds with and without setting CC and CXX.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.