Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update aws-efa-nccl-tests docker file to the latest cuda and nccl version #446

Merged
merged 2 commits into from
Jun 6, 2024

Conversation

weicongw
Copy link
Contributor

@weicongw weicongw commented Jun 6, 2024

Issue #, if available:

Description of changes:
Update aws-efa-nccl-tests docker file to the latest cuda and nccl version. Tested with EKS cluster.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@weicongw weicongw marked this pull request as ready for review June 6, 2024 21:25
@cartermckinnon
Copy link
Member

cartermckinnon commented Jun 6, 2024

@weicongw can you add a block to the PR checks for this, so we can make sure it builds after this (and any future) changes?

example:

build-kubetest2:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- run: docker build --build-arg=KUBERNETES_MINOR_VERSION=latest --file Dockerfile.kubetest2 .

@cartermckinnon cartermckinnon merged commit e89b57c into aws:main Jun 6, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants