accept amitype in kubetest2 managed nodegroup creation #438
Conversation
|
I think we should add validation that a |
ndbaker1
force-pushed
the
amitype
branch
2 times, most recently
from
80e28c7
to
605d7e4
Compare
| if d.AMIType != "" && d.AMI != "" { | ||
| return fmt.Errorf("Cannot accept mutually exclusive flags --ami-type and --ami because it implies conflicting deployment modes") |
There was a problem hiding this comment.
need some suggestion on this message/condition. we don't validate you can't provide the --ami flag if you're not using unmanaged nodes, so not sure whether enforcing this is useful in practice @cartermckinnon
There was a problem hiding this comment.
I think it'd be nice to validate that too :) but it's fine to just say "these two flags are mutually exclusive" in the error message, the flag docs can explain when/how a flag is used
There was a problem hiding this comment.
validating each on their own according to --unmanaged-nodes handles the mutual exclusion and i think is clearer. small update with this
Issue #, if available:
Description of changes:
add a flag to pass
ami-typeto the nodegroup creation for kubetest2 deployerBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.