Switch to cmake for protobuf library build #63
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hefroy
reviewed
Aug 10, 2023
csxwin
force-pushed
the
build-protobuf-lib-via-cmake
branch
from
b6d4f10
to
d5220e5
Compare
csxwin
force-pushed
the
build-protobuf-lib-via-cmake
branch
from
d5220e5
to
968e50d
Compare
|
Close this PR as the CI is failing due to ubuntu packaging. Hence this change will be bundled with the packaging fix in a future PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request are making changes to the install dependency scripts. It will make two chagnes:
DCMAKE_POSITION_INDEPENDENT_CODEso that the static library can be consumed by shared target buildBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.