fix(sdk): always re-evaluate termination after checkpoint queue drains#526
Draft
ayushiahjolia wants to merge 1 commit into
Draft
fix(sdk): always re-evaluate termination after checkpoint queue drains#526ayushiahjolia wants to merge 1 commit into
ayushiahjolia wants to merge 1 commit into
Conversation
ParidelPooya
requested changes
May 7, 2026
Contributor
ParidelPooya
left a comment
There was a problem hiding this comment.
I ran new added examples and integration test with and without the fix (change to checkpoint-manager), ignoring assertEventSignatures, integration test are passing before and after the change.
That means that we didn't manage to reproduce the customer issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #510
Description of changes:
Removes the
if (!this.terminationTimer)guard in processQueue's finally block so that termination is always re-evaluated after the checkpoint queue drains.Problem
In map + waitForCallback scenarios, callbacks register as IDLE_AWAITED and set terminationTimer before a completed branch's fire-and-forget checkpoint enters the queue. When the queue drains, the guard sees terminationTimer is
non-null and skips checkAndTerminate. The function never suspends - it wedges until an unrelated timer (e.g., a sibling ctx.wait) fires.
Fix
Replace the conditional with an unconditional
this.checkAndTerminate().This is safe because
scheduleTerminationalready returns early when the same reason is already scheduled — no timer restart, no extra cooldown in the common case.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.