-
Notifications
You must be signed in to change notification settings - Fork 10
feat(plugin): add onOperationChange hook #527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
nvasiu
wants to merge
1
commit into
main
Choose a base branch
from
operation-change-hook
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
23 changes: 23 additions & 0 deletions
23
sdk/src/main/java/software/amazon/lambda/durable/plugin/OperationChangeInfo.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| // Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved. | ||
| // SPDX-License-Identifier: Apache-2.0 | ||
| package software.amazon.lambda.durable.plugin; | ||
|
|
||
| import java.util.Map; | ||
|
|
||
| /** | ||
| * Information provided when a checkpoint response changes one or more operations. | ||
| * | ||
| * <p>Holds a map with an {@link OperationChangeItemInfo} for every operation that changed in the checkpoint response. | ||
| * | ||
| * @param requestId the Lambda request ID for the invocation that observed the change | ||
| * @param durableExecutionArn the durable execution ARN | ||
| * @param updatedOperations operations whose status changed in this checkpoint response, keyed by operation ID | ||
| * @param operations a snapshot of all known operations after the update, keyed by operation ID | ||
| * @deprecated This is a preview API that is experimental and may be changed or removed in future releases. | ||
| */ | ||
| @Deprecated | ||
| public record OperationChangeInfo( | ||
| String requestId, | ||
| String durableExecutionArn, | ||
| Map<String, OperationChangeItemInfo> updatedOperations, | ||
| Map<String, OperationChangeItemInfo> operations) {} |
32 changes: 32 additions & 0 deletions
32
sdk/src/main/java/software/amazon/lambda/durable/plugin/OperationChangeItemInfo.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| // Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved. | ||
| // SPDX-License-Identifier: Apache-2.0 | ||
| package software.amazon.lambda.durable.plugin; | ||
|
|
||
| import java.time.Instant; | ||
| import software.amazon.awssdk.services.lambda.model.OperationStatus; | ||
|
|
||
| /** | ||
| * Operation-level information for a single operation within an {@link OperationChangeInfo}. | ||
| * | ||
| * @param id operation ID | ||
| * @param name human-readable operation name (may be null) | ||
| * @param type operation type | ||
| * @param subType operation sub-type (may be null) | ||
| * @param parentId parent operation ID (null for root-level operations) | ||
| * @param startTimestamp when the operation started | ||
| * @param endTimestamp when the operation ended | ||
| * @param error non-null if the operation failed | ||
| * @param status operation status | ||
| * @deprecated This is a preview API that is experimental and may be changed or removed in future releases. | ||
| */ | ||
| @Deprecated | ||
| public record OperationChangeItemInfo( | ||
| String id, | ||
| String name, | ||
| String type, | ||
| String subType, | ||
| String parentId, | ||
| Instant startTimestamp, | ||
| Instant endTimestamp, | ||
| Throwable error, | ||
| OperationStatus status) {} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it a concern to pass the same object to multiple plugins? One plugin could potentially modify the object and impact the others
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated, the maps inside
OperationChangeInfoare now immutable, so this shouldnt be a concern anymore.