fix: throw IllegalStateException when validation of thread type fail#477
Open
zhongkechen wants to merge 1 commit into
Open
fix: throw IllegalStateException when validation of thread type fail#477zhongkechen wants to merge 1 commit into
zhongkechen wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Issue Link, if available
Fix #455
Description
When a user calls a durable method from the wrong thread, e.g. calling
durableFuture.get()from a step ,currently
IllegalDurableOperationExceptionis thrown and the execution is immediately terminated.IllegalDurableOperationExceptionis supposed to be used in critical situation, e.g. SDK bugs or API bugs. Validation errors like above is user triggered and we shouldn't useIllegalDurableOperationExceptionin this case.Demo/Screenshots
Checklist
Testing
Unit Tests
Have unit tests been written for these changes?
Integration Tests
Have integration tests been written for these changes?
Examples
Has a new example been added for the change? (if applicable)