Skip to content

Add subtype to checkpoint updates in BaseDurableOperation #212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nvasiu merged 1 commit into from
Mar 13, 2026
Merged

Add subtype to checkpoint updates in BaseDurableOperation #212

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions sdk/src/main/java/software/amazon/lambda/durable/operation/BaseDurableOperation.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -263,11 +263,12 @@ protected void sendOperationUpdate(OperationUpdate.Builder builder) {
}

protected CompletableFuture<Void> sendOperationUpdateAsync(OperationUpdate.Builder builder) {
return executionManager.sendOperationUpdate(builder.id(getOperationId())
.name(getName())
.type(getType())
.parentId(durableContext.getContextId())
.build());
var updateBuilder =
builder.id(getOperationId()).name(getName()).type(getType()).parentId(durableContext.getContextId());
if (getSubType() != null) {
updateBuilder.subType(getSubType().getValue());
}
return executionManager.sendOperationUpdate(updateBuilder.build());
}

// serialization/deserialization utilities
Expand Down
17 changes: 5 additions & 12 deletions sdk/src/main/java/software/amazon/lambda/durable/operation/ChildContextOperation.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,9 +60,7 @@ public ChildContextOperation(
@Override
protected void start() {
// First execution: fire-and-forget START checkpoint, then run
sendOperationUpdateAsync(OperationUpdate.builder()
.action(OperationAction.START)
.subType(getSubType().getValue()));
sendOperationUpdateAsync(OperationUpdate.builder().action(OperationAction.START));
executeChildContext();
}

Expand Down Expand Up @@ -139,17 +137,14 @@ private void checkpointSuccess(T result) {
var serializedBytes = serialized.getBytes(StandardCharsets.UTF_8);

if (serializedBytes.length < LARGE_RESULT_THRESHOLD) {
sendOperationUpdate(OperationUpdate.builder()
.action(OperationAction.SUCCEED)
.subType(getSubType().getValue())
.payload(serialized));
sendOperationUpdate(
OperationUpdate.builder().action(OperationAction.SUCCEED).payload(serialized));
} else {
// Large result: checkpoint with empty payload + ReplayChildren flag.
// Store the result so get() can return it directly without deserializing the empty payload.
this.reconstructedResult = result;
sendOperationUpdate(OperationUpdate.builder()
.action(OperationAction.SUCCEED)
.subType(getSubType().getValue())
.payload("")
.contextOptions(
ContextOptions.builder().replayChildren(true).build()));
Expand All @@ -173,10 +168,8 @@ private void handleChildContextFailure(Throwable exception) {
errorObject = serializeException(exception);
}

sendOperationUpdate(OperationUpdate.builder()
.action(OperationAction.FAIL)
.subType(getSubType().getValue())
.error(errorObject));
sendOperationUpdate(
OperationUpdate.builder().action(OperationAction.FAIL).error(errorObject));
}

@Override
Expand Down
Loading