fix(.NET): Improve Collection of Errors string #1534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| public CollectionOfErrors(string message) : base(message) { this.list = new System.Collections.Generic.List<Exception>(); } | ||
| public CollectionOfErrors() : base("CollectionOfErrors") { this.list = new System.Collections.Generic.List<Exception>(); } | ||
| private static string ListAsString(List<Exception> list) |
There was a problem hiding this comment.
Do we need to import System.Collections.Generic.List or use System.Collections.Generic.List<Exception> instead of List<Exception>?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Collection of Errors is a frustrating error because it requires customer action
to completely serialize it into logs.
We can make a simple fix in .NET to improve the CX,
by always serializing the list into the Collection Of Error's
message.
We concatenate the given error message with
a serialization of all the nested errors.
See similar PR for MPL-Java: aws/aws-cryptographic-material-providers-library@9e195a1
Squash/merge commit message, if applicable:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.