-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: enhanced search capability #83
base: main
Are you sure you want to change the base?
feature: enhanced search capability #83
Conversation
Any questions or requests I can help answer on this so we can get it merged in? |
This PR has been sitting for quite a while. Any chance this is even on the radar to get merged in? |
One last effort here to get any kind of feedback from anyone on the team, otherwise we will just fork this and manage it on our own. Is this even worth me going through and fixing all this stuff so that we can get this in? |
@aaronatbissell, we are once again evaluating PRs to be merge. If you are able to fix the recent conflicts, we can review and merge this update. |
Hello @aaronatbissell, are you planning to work on this PR? We plan to close this on 9/8/23 for tracking purposes if it's not still active (in that case, please re-open it if/when you have update it). Thank you |
I can also try to work on this one, but most of this PR was written by an AWS team member formerly on the CDF team. I made a few small tweaks at the end and submitted the PR. Won't be able to get to this for about a month, but I will try. |
…lidate OpenSearch instance type
…ation documentation
…ng enhanced AL migration
…er access to open search
0b4a07b
to
16aabfe
Compare
@ts-amz - rebased on main. This will probably need some extensive testing |
Description
Type of change
This branch makes a couple of small tweaks to the enhanced search capability initially developed by @jonasneu-aws, specifically, the below updates:
cdf-network-<cdf-environment-name>
, but I had to use "The NeptuneSecurityGroupID output of the stackcdf-assetlibrary-neptune-<cdf-environment-name>
”. The Neptune export Batch job was timing out after 30 seconds of trying to connect to Neptune unless I used this other security group.Submission Checklist
Additional Notes: