Skip to content

Conversation

@aemous
Copy link
Contributor

@aemous aemous commented Dec 12, 2025

Description of changes:

  • For all public function signatures modified in Merge --v2-debug migration debug mode to develop #9905, modified their signatures so that the new arguments are added to the end with defaults provided.
  • For new callback handlers using the new remaining_args argument on the top-level-args-parsed event, update them to handle the case that remaining_args is None, for backwards compatibility.
  • For the top-level-args event emission, move the new remaining_args argument to the end, to avoid breaking existing

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Description of tests:

  • Successfully ran and passed all unit and functional tests.
  • Successfully ran a test build.

@codecov-commenter
Copy link

codecov-commenter commented Dec 12, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.34%. Comparing base (5a98bdf) to head (da11c28).
⚠️ Report is 137 commits behind head on debug-migration.

Additional details and impacted files
@@                 Coverage Diff                 @@
##           debug-migration    #9916      +/-   ##
===================================================
+ Coverage            93.32%   93.34%   +0.02%     
===================================================
  Files                  209      209              
  Lines                16909    16938      +29     
===================================================
+ Hits                 15780    15811      +31     
+ Misses                1129     1127       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@aemous aemous marked this pull request as ready for review December 12, 2025 19:17
@aemous aemous merged commit ecfe731 into aws:debug-migration Dec 15, 2025
48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants