Extract ECS monitoring data collection to ServiceViewCollector #9907
+1,323
−1,173
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jutyler1
force-pushed
the
ecs-pr-v4-01
branch
3 times, most recently
from
3b77652 to
889246d
Compare
jutyler1
force-pushed
the
ecs-pr-v4-01
branch
2 times, most recently
from
7e75327 to
03ab91b
Compare
aemous
requested changes
Dec 11, 2025
Contributor
aemous
left a comment
aemous
left a comment
There was a problem hiding this comment.
Looks good overall, left some minor comments.
jutyler1
force-pushed
the
ecs-pr-v4-01
branch
2 times, most recently
from
8670413 to
6d5c161
Compare
jutyler1
force-pushed
the
ecs-pr-v4-01
branch
from
6d5c161 to
edd8124
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Separating out logic that queries ECS from logic the controls the monitoring behavior.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.