Skip to content

Conversation

@aemous
Copy link
Contributor

@aemous aemous commented Dec 10, 2025

Description of changes:

  • Modify the us-east-1 S3 endpoint check so that:
    • It restricts the s3.amazonaws.com check to the hostname of the URL. This prevents false positives, for example, when the object key/prefix contains s3.amazonaws.com.
    • It does not trigger detection when --endpoint-url is used.
    • If the region is configured to something other than us-east-1, it will not trigger detection.
  • Switch changelog entry from enhancement type to feature.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@aemous aemous requested a review from a team December 10, 2025 17:23
@aemous aemous changed the title Modify debug migration endpoint URL check to check hostname Modify debug migration s3 us-east-1 detections Dec 10, 2025
@codecov-commenter
Copy link

codecov-commenter commented Dec 10, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.33%. Comparing base (5a98bdf) to head (49688a6).
⚠️ Report is 7 commits behind head on debug-migration.

Additional details and impacted files
@@               Coverage Diff                @@
##           debug-migration    #9906   +/-   ##
================================================
  Coverage            93.32%   93.33%           
================================================
  Files                  209      209           
  Lines                16909    16912    +3     
================================================
+ Hits                 15780    15784    +4     
+ Misses                1129     1128    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@aemous aemous merged commit 57d0a24 into aws:debug-migration Dec 11, 2025
48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants