Assume Role to find EKS cluster for config update#9364
Closed
5nafu wants to merge 1 commit intoaws:developfrom
Closed
Assume Role to find EKS cluster for config update#93645nafu wants to merge 1 commit intoaws:developfrom
5nafu wants to merge 1 commit intoaws:developfrom
Conversation
This commit will assume a given role when trying to update the kubeconfig. While `aws eks update-kubeconfig --role-arn...` would add the required parameters to the user section of the configfile, but will fail finding the cluster if the original profile does not have access. This commit will fix the issue and assume the role before getting the cluster description. Fixes aws#8554
|
Hi, I'm on the team working on EKS at AWS. As I understand:
Better would be to implement the suggestions from here, perhaps with the latter of providing another parameter so that the two roles can be clearly separated. If you're willing to make that change for adding a new parameter (and update the documentation), we'd be happy to approve it. |
Contributor
Contributor
Closing this PR as it has been superseded, and the reworked version has been merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #8554
Description of changes:
This PR will assume a given role when trying to update the kubeconfig.
While
aws eks update-kubeconfig --role-arn...would add the required parameters to the user section of the configfile, but will fail finding the cluster if the original profile does not have access. This PR will fix the issue and assume the role before getting the cluster description.