Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to HealthLake examples #9096

Open
wants to merge 8 commits into
base: develop
Choose a base branch
from

Conversation

meyertst-aws
Copy link
Contributor

Description of changes:

This update the examples for HealthLake

Fixes minor issue in numerous examples.
Adds a SMART on fhir example for create_fhir_datastore

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@meyertst-aws meyertst-aws changed the title 6764 cli healthimaging update examples Update to HealthLake examples Nov 21, 2024
@cmcgru
Copy link

cmcgru commented Dec 5, 2024

@larencra implemented a flag for the HealthImaging docs to remove a para that pointed back to the same page in the Developer Guide that it was linked to. Please apply the same flag for all HealthLake CLI examples. See attached screen capture for an example of what I'm describing.

Screenshot 2024-12-05 at 10 03 10 AM

@elysahall elysahall self-requested a review December 10, 2024 17:18
@elysahall elysahall added documentation This is a problem with documentation. pr:work-in-progress This PR is a draft and needs further work. labels Dec 10, 2024
@cmcgru
Copy link

cmcgru commented Dec 10, 2024

Thanks, Elysa. One last request: please update all non-code instances of Amazon HealthLake to AWS HealthLake.
Screenshot 2024-12-10 at 4 23 38 PM

@elysahall elysahall self-assigned this Dec 13, 2024
Copy link
Collaborator

@elysahall elysahall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your submission! There were a couple issues. Please fix these formatting issues and push your updates.

@elysahall elysahall removed their assignment Dec 13, 2024
Update Data Store to data store
Update Datastore to data store
@meyertst-aws meyertst-aws force-pushed the 6764-cli-healthimaging-update-examples branch from 7a6aab3 to 2774bf4 Compare December 17, 2024 14:56
Copy link
Collaborator

@elysahall elysahall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elysahall elysahall added pr:needs-review This PR needs a review from a Member. and removed pr:work-in-progress This PR is a draft and needs further work. labels Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation This is a problem with documentation. pr:needs-review This PR needs a review from a Member.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants