Avoid shell for Windows CodeDeploy MSI install#10368
Open
dfgvaetyj3456356-hash wants to merge 2 commits into
Open
Avoid shell for Windows CodeDeploy MSI install#10368dfgvaetyj3456356-hash wants to merge 2 commits into
dfgvaetyj3456356-hash wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The Windows CodeDeploy on-premises installer currently invokes the downloaded MSI by passing the relative installer path to
subprocess.check_call(..., shell=True). This change runs the MSI throughmsiexec.exe /iand removes shell invocation from that install step.This keeps the existing quiet install and log arguments, while avoiding shell parsing for custom installer filenames supplied through
--agent-installer.Tests
python -m pytest tests\unit\customizations\codedeploy\test_systems.py tests\unit\customizations\codedeploy\test_install.py -qgit diff --check