-
Notifications
You must be signed in to change notification settings - Fork 4.4k
fix(elasticloadbalancingv2): improve handling for dropInvalidHeaderFields in case of default or switching from true to false
#36483
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
… false values for dropInvalidHeaderFields.
…lds for default and and once switching from true to false
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(This review is outdated)
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
|
|
||||||||||||||
|
|
||||||||||||||
…er generate t automatically
aws-cdk-automation
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request linter fails with the following errors:
❌ Fixes must contain a change to an integration test file and the resulting snapshot.
If you believe this pull request should receive an exemption, please comment and provide a justification. A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed, add Clarification Request to a comment.
|
Clarification Request |
Issue # (if applicable)
Closes #36409
Reason for this change
Previously, the
dropInvalidHeaderFieldsproperty (in CFNrouting.http.drop_invalid_header_fields.enabled) was only set in the CloudFormation (CFN) template when explicitly set totrue. When set tofalse, the attribute was omitted from the template, making it impossible for CloudFormation to detect configuration drift or properly update the ALB when the property value changed fromtruetofalse.Description of changes
Modified dropInvalidHeaderFields behavior: Changed from conditional setting (only when true) to explicit setting for both true and false values. This should help CloudFormation change set and/or drift detection as well (I love CFN drift detection 🫶).
Added tests: Created test cases covering both true/false values and undefined behavior to ensure proper CloudFormation template generation
Description of how you validated changes
Tried to ensured existing functionality remains unchanged while adding support for explicit false values.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license