Skip to content

Conversation

@rgoltz
Copy link

@rgoltz rgoltz commented Dec 22, 2025

Issue # (if applicable)

Closes #36409

Reason for this change

Previously, the dropInvalidHeaderFields property (in CFN routing.http.drop_invalid_header_fields.enabled) was only set in the CloudFormation (CFN) template when explicitly set to true. When set to false, the attribute was omitted from the template, making it impossible for CloudFormation to detect configuration drift or properly update the ALB when the property value changed from true to false.

Description of changes

  • Modified dropInvalidHeaderFields behavior: Changed from conditional setting (only when true) to explicit setting for both true and false values. This should help CloudFormation change set and/or drift detection as well (I love CFN drift detection 🫶).

  • Added tests: Created test cases covering both true/false values and undefined behavior to ensure proper CloudFormation template generation

Description of how you validated changes

Tried to ensured existing functionality remains unchanged while adding support for explicit false values.

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

…lds for default and and once switching from true to false
@github-actions github-actions bot added the beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK label Dec 22, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team December 22, 2025 18:39
@github-actions github-actions bot added bug This issue is a bug. effort/small Small work item – less than a day of effort p2 labels Dec 22, 2025
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This review is outdated)

@aws-cdk-automation aws-cdk-automation dismissed their stale review December 22, 2025 18:49

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 22, 2025

⚠️ Experimental Feature: This security report is currently in experimental phase. Results may include false positives and the rules are being actively refined.
Please try merge from main to avoid findings unrelated to the PR.


TestsPassed ✅SkippedFailed
Security Guardian Results25 ran25 passed
TestResult
No test annotations available

@github-actions
Copy link
Contributor

github-actions bot commented Dec 22, 2025

⚠️ Experimental Feature: This security report is currently in experimental phase. Results may include false positives and the rules are being actively refined.
Please try merge from main to avoid findings unrelated to the PR.


TestsPassed ✅SkippedFailed
Security Guardian Results with resolved templates25 ran25 passed
TestResult
No test annotations available

Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter fails with the following errors:

❌ Fixes must contain a change to an integration test file and the resulting snapshot.

If you believe this pull request should receive an exemption, please comment and provide a justification. A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed, add Clarification Request to a comment.

@rgoltz
Copy link
Author

rgoltz commented Dec 22, 2025

Clarification Request

@aws-cdk-automation aws-cdk-automation added the pr/reviewer-clarification-requested The contributor has requested clarification on feedback, a failing build, or a failing PR Linter run label Dec 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK bug This issue is a bug. effort/small Small work item – less than a day of effort p2 pr/reviewer-clarification-requested The contributor has requested clarification on feedback, a failing build, or a failing PR Linter run

Projects

None yet

Development

Successfully merging this pull request may close these issues.

(aws-elasticloadbalancingv2): dropInvalidHeaderFields not reflected in CloudFormation when set from true to false

2 participants