-
Notifications
You must be signed in to change notification settings - Fork 4.4k
fix(ec2): add proper handling for VPC endpoint service name prefix eu.amazonaws for new region eusc-de-east-1 for ECR & API Gateway services #36471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(This review is outdated)
f26c349 to
777dafd
Compare
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
777dafd to
5d96177
Compare
5d96177 to
2468dbd
Compare
CONTRIBUTORS.md
Outdated
| - [salah1994-sys](https://github.com/salah1994-sys) | ||
|
|
||
|
|
||
| _Last updated: Mon, 01 Dec 25 00:16:16 +0000_ | ||
| _Last updated: Mon, 22 Dec 25 14:16:16 +0000_ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file is updated automatically by a bot when reaching a specific number of contributions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, updated the commit, removed changes made to CONTRIBUTORS.md
|
|
||||||||||||||||||
|
|
||||||||||||||
2468dbd to
ced186a
Compare
….amazonaws for new region eusc-de-east-1 for ECR & API Gateway services
ced186a to
e05fea1
Compare
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Merge Queue Status✅ The pull request has been merged at e05fea1 This pull request spent 5 seconds in the queue, with no time running CI. Required conditions to merge
|
|
Comments on closed issues and PRs are hard for our team to see. |
Reason for this change
For the new region
eusc-de-east-1will be launched in AWS European Sovereign Cloud, services like:-They have their VPC endpoint service name starts with prefix
eu.amazonawsrather than the defaultcom.amazonawsThis requires special handling similar to what's already implemented for China regions
cn-north-1&cn-northwest-1otherwise, while deploying, CloudFormation stacks will hit the error "The Vpc Endpoint Servicecom.amazonaws.eusc-de-east-1.ecr.dkrdoes not exist"Description of changes
In the file
packages/aws-cdk-lib/aws-ec2/lib/vpc-endpoint.ts, I am updating the methodgetDefaultEndpointPrefix, adding special handling foreusc-de-east-1when services are['ecr.dkr', 'ecr.api', 'execute-api', 'securityhub']to returneu.amazonawsinstead ofcom.amazonaws. This is similar to what's already existing for China regions.Description of how you validated changes
I also updated
packages/aws-cdk-lib/aws-ec2/test/vpc-endpoint.test.tsto cover unit tests and was confirmed tests are passedChecklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license