-
Notifications
You must be signed in to change notification settings - Fork 4.3k
feat(agentcore): add agentcore L2 constructs for 1p tools #35577
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Build failures seem to come from other packages, not this contribution |
packages/@aws-cdk/aws-bedrock-agentcore-alpha/agentcore/tools/perms.ts
Outdated
Show resolved
Hide resolved
packages/@aws-cdk/aws-bedrock-agentcore-alpha/agentcore/tools/code-interpreter.ts
Outdated
Show resolved
Hide resolved
packages/@aws-cdk/aws-bedrock-agentcore-alpha/agentcore/tools/browser.ts
Show resolved
Hide resolved
packages/@aws-cdk/aws-bedrock-agentcore-alpha/agentcore/tools/browser.ts
Outdated
Show resolved
Hide resolved
packages/@aws-cdk/aws-bedrock-agentcore-alpha/agentcore/tools/code-interpreter.ts
Show resolved
Hide resolved
packages/@aws-cdk/aws-bedrock-agentcore-alpha/agentcore/tools/code-interpreter.ts
Outdated
Show resolved
Hide resolved
Pull request has been modified.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also saw that the build is failing after the last round of changes due to low unit test coverage (or at least lower than expected). Lets make sure that gets fixed too please. Once we resolve all this, I think this construct will be ready and just waiting to be merged.
packages/@aws-cdk/aws-bedrock-agentcore-alpha/agentcore/tools/browser.ts
Outdated
Show resolved
Hide resolved
packages/@aws-cdk/aws-bedrock-agentcore-alpha/agentcore/tools/browser.ts
Outdated
Show resolved
Hide resolved
Pull request has been modified.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one tiny change that shouldn't affect anything else. Once fixed this PR can be considered finished and approval ready at the current state. I know a modification will be needed once the VPC mode is released, but for now we are good to go
Issue # (if applicable)
Related to aws/aws-cdk-rfcs#785
Reason for this change
Adding a new alpha package for Amazon Bedrock AgentCore and add support for 1p tools (Browser, Code Interpreter).
Description of changes
Describe any new or updated permissions being added
Using permissions for agent core defined in https://docs.aws.amazon.com/service-authorization/latest/reference/list_amazonbedrockagentcore.html
Description of how you validated changes
Unit tests, integration tests, manual tests
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license