-
Notifications
You must be signed in to change notification settings - Fork 4.3k
feat(aws-servicecatalogappregistry-alpha): add attributes property to AttributeGroup import #35556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request linter fails with the following errors:
❌ Features must contain a change to an integration test file and the resulting snapshot.
❌ The title scope of the pull request should omit 'aws-' from the name of modified packages. Use 'servicecatalogappregistry-alpha' instead of 'aws-servicecatalogappregistry-alpha'.
If you believe this pull request should receive an exemption, please comment and provide a justification. A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed, add Clarification Request to a comment.
…ributeGroup import
accc5d2 to
38b1337
Compare
|
Hello @pahud |
|
This PR has been in the CHANGES REQUESTED state for 3 weeks, and looks abandoned. Note that PRs with failing linting check or builds are not reviewed, please ensure your build is passing To prevent automatic closure:
This PR will automatically close in 14 days if no action is taken. |
|
@pahud |
|
This PR has been deemed to be abandoned, and will be automatically closed. Please create a new PR for these changes if you think this decision has been made in error. |
|
Comments on closed issues and PRs are hard for our team to see. |
|
Hi @naaa760 I don't have the privilege to review PRs. Looks like this PR was closed unexpectedly and I just reopened. Please make sure all CI pass with no conflict and our maintainer will review your PR when it's ready. |
|
This PR has been deemed to be abandoned, and will be automatically closed. Please create a new PR for these changes if you think this decision has been made in error. |
Closes #35524.
Reason for this change
fromAttributeGroupArnmethod only creates a reference to an existing AttributeGroup but doesn't provide access to the stored attributes. This limits the usefulness of AttributeGroups as a centralized configuration store, forcing users to use SSM parameters for sharing configuration objects across multiple accounts.Description of changes
attributesparameter to thefromAttributeGroupArnmethod and added anattributesproperty to theIAttributeGroupinterface. This allows users to provide attributes when importing an AttributeGroup, enabling access to stored configuration data.Changes made:
attributes?: { [key: string]: any }property toIAttributeGroupinterfaceattributesproperty toAttributeGroupBaseabstract classfromAttributeGroupArnmethod signature to accept optionalattributesparameterattributesproperty to concreteAttributeGroupclassattributesproperty from propsDesign decisions:
attributesoptional to maintain backward compatibility{ [key: string]: any }as the existingAttributeGroupProps.attributesDescribe any new or updated permissions being added
Description of how you validated changes