Skip to content

Conversation

@naaa760
Copy link

@naaa760 naaa760 commented Sep 23, 2025

Closes #35524.

Reason for this change

  • The current fromAttributeGroupArn method only creates a reference to an existing AttributeGroup but doesn't provide access to the stored attributes. This limits the usefulness of AttributeGroups as a centralized configuration store, forcing users to use SSM parameters for sharing configuration objects across multiple accounts.

Description of changes

  • Added an optional attributes parameter to the fromAttributeGroupArn method and added an attributes property to the IAttributeGroup interface. This allows users to provide attributes when importing an AttributeGroup, enabling access to stored configuration data.

Changes made:

  • Added attributes?: { [key: string]: any } property to IAttributeGroup interface
  • Added attributes property to AttributeGroupBase abstract class
  • Updated fromAttributeGroupArn method signature to accept optional attributes parameter
  • Added attributes property to concrete AttributeGroup class
  • Updated constructor to set the attributes property from props

Design decisions:

  • Made attributes optional to maintain backward compatibility
  • Used the same type { [key: string]: any } as the existing AttributeGroupProps.attributes
  • No breaking changes to existing API

Describe any new or updated permissions being added

  • No new IAM permissions are required. This change only affects the CDK construct interface and doesn't modify AWS resource permissions.

Description of how you validated changes

  • Added unit tests to verify importing AttributeGroup with and without attributes
  • Added test to verify accessing attributes from newly created AttributeGroup
  • All existing tests continue to pass, ensuring backward compatibility

@aws-cdk-automation aws-cdk-automation requested a review from a team September 23, 2025 08:02
@github-actions github-actions bot added effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2 beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK labels Sep 23, 2025
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter fails with the following errors:

❌ Features must contain a change to an integration test file and the resulting snapshot.
❌ The title scope of the pull request should omit 'aws-' from the name of modified packages. Use 'servicecatalogappregistry-alpha' instead of 'aws-servicecatalogappregistry-alpha'.

If you believe this pull request should receive an exemption, please comment and provide a justification. A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed, add Clarification Request to a comment.

@naaa760
Copy link
Author

naaa760 commented Sep 29, 2025

Hello @pahud
would you please review this PR?

@aws-cdk-automation
Copy link
Collaborator

This PR has been in the CHANGES REQUESTED state for 3 weeks, and looks abandoned. Note that PRs with failing linting check or builds are not reviewed, please ensure your build is passing

To prevent automatic closure:

  • Resume work on the PR
  • OR request an exemption by adding a comment containing 'Exemption Request' with justification e.x "Exemption Request: "
  • OR request clarification by adding a comment containing 'Clarification Request' with a question e.x "Clarification Request: "

This PR will automatically close in 14 days if no action is taken.

@naaa760
Copy link
Author

naaa760 commented Oct 16, 2025

@pahud
please check!

@aws-cdk-automation
Copy link
Collaborator

This PR has been deemed to be abandoned, and will be automatically closed. Please create a new PR for these changes if you think this decision has been made in error.

@aws-cdk-automation aws-cdk-automation added the closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. label Oct 29, 2025
@github-actions
Copy link
Contributor

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 29, 2025
@pahud pahud reopened this Oct 29, 2025
@pahud
Copy link
Contributor

pahud commented Oct 29, 2025

Hi @naaa760

I don't have the privilege to review PRs. Looks like this PR was closed unexpectedly and I just reopened. Please make sure all CI pass with no conflict and our maintainer will review your PR when it's ready.

@pahud pahud removed the closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. label Oct 29, 2025
@aws-cdk-automation
Copy link
Collaborator

This PR has been deemed to be abandoned, and will be automatically closed. Please create a new PR for these changes if you think this decision has been made in error.

@aws-cdk-automation aws-cdk-automation added the closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. label Oct 30, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

(aws-servicecatalogappregistry-alpha): Add retrieving of attributes from construct

3 participants