Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add ianhou to mergify and GH merit badger configs #32759

Merged
merged 4 commits into from
Jan 7, 2025
Merged

Conversation

iankhou
Copy link
Contributor

@iankhou iankhou commented Jan 6, 2025

Issue # (if applicable)

N/A.

Reason for this change

Onboarding a new engineer.

Description of changes

Configuration changes only. Added iankhou (ianhou@) to exception list for GH merit badger and to Mergify config.

Describe any new or updated permissions being added

<!— What new or updated IAM permissions are needed to support the changes being introduced ? -->

No changes in IAM are required.

Description of how you validated changes

Config change only, no tests were changed.

Checklist - N/A


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK p2 labels Jan 6, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team January 6, 2025 21:53
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@iankhou iankhou changed the title Add iankhou to mergify and GH merit badger configs Add ianhou to mergify and GH merit badger configs Jan 6, 2025
Copy link

codecov bot commented Jan 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.52%. Comparing base (6218f3a) to head (8eb0cd0).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #32759   +/-   ##
=======================================
  Coverage   81.52%   81.52%           
=======================================
  Files         222      222           
  Lines       13715    13715           
  Branches     2417     2417           
=======================================
  Hits        11181    11181           
  Misses       2254     2254           
  Partials      280      280           
Flag Coverage Δ
suite.unit 81.52% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
packages/aws-cdk 80.97% <ø> (ø)
packages/aws-cdk-lib/core 82.09% <ø> (ø)

@iankhou iankhou changed the title Add ianhou to mergify and GH merit badger configs chore: Add ianhou to mergify and GH merit badger configs Jan 6, 2025
@iankhou iankhou changed the title chore: Add ianhou to mergify and GH merit badger configs chore: add ianhou to mergify and GH merit badger configs Jan 6, 2025
@aws-cdk-automation aws-cdk-automation dismissed their stale review January 6, 2025 22:12

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

kaizencc
kaizencc previously approved these changes Jan 6, 2025
Copy link
Contributor

mergify bot commented Jan 6, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Copy link
Contributor

mergify bot commented Jan 6, 2025

This pull request has been removed from the queue for the following reason: pull request dequeued.

Pull request #32759 has been dequeued. The pull request has been synchronized by a user

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.

If you want to requeue this pull request, you need to post a comment with the text: @mergifyio requeue

@mergify mergify bot dismissed kaizencc’s stale review January 6, 2025 22:52

Pull request has been modified.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 8eb0cd0
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@kaizencc kaizencc merged commit c57debb into main Jan 7, 2025
19 checks passed
@kaizencc kaizencc deleted the ian-cfgs branch January 7, 2025 16:09
Copy link

github-actions bot commented Jan 7, 2025

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 7, 2025
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Jan 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK contribution/core This is a PR that came from AWS. p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants