-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add feature flag report to package #32607
base: main
Are you sure you want to change the base?
Conversation
Include a file `recommended-feature-flags.json` into the `aws-cdk-lib` package. The CLI will read this file when it creates a new project.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request
. Additionally, if clarification is needed add Clarification Request
to a comment.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #32607 +/- ##
==========================================
+ Coverage 79.13% 79.21% +0.08%
==========================================
Files 107 107
Lines 7131 7154 +23
Branches 1319 1326 +7
==========================================
+ Hits 5643 5667 +24
Misses 1304 1304
+ Partials 184 183 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
➡️ PR build request submitted to A maintainer must now check the pipeline and add the |
The pull request linter fails with the following errors:
PRs must pass status checks before we can provide a meaningful review. If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing |
Include a file
recommended-feature-flags.json
into theaws-cdk-lib
package.At build time, the CLI will copy the current
aws-cdk-lib
andconstructs
version, as well as the feature flag report, into its own package directory, and it will use those to initialize a new project.This decouples the init version number from the CLI version number, and it removes the need for the CLI to read
cx-api
at init time.Closes https://github.com/aws/aws-cdk-cli/issues/7
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license