Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(lambda-python-alpha): make pipenv version a parameter for bundling #32594

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dil-emiravalles
Copy link

Make pipenv version a parameter in the Dockerfile for python lambda bundling. It was originally hardcoded to 2022.4.8, which excluded newer features/fixes.

Issue # (if applicable)

None.

Reason for this change

Pipenv version was originally hardcoded to 2022.4.8, which excluded newer features/fixes. And that could not be changed without providing a new Dockerfile from scratch.

Description of changes

Just made the pipenv version a new ARG in the Dockerfile. So that it can be provided from the outside.

It has the same default value as it used to have, so that the current behavior won't change.

Describe any new or updated permissions being added

None

Description of how you validated changes

Tested this same Dockerfile in my current project, providing the PIPENV_VERSION variable via CDK:

import * as python from '@aws-cdk/aws-lambda-python-alpha';

const lambdaProps: python.PythonFunctionProps = {
  runtime: lambda.Runtime.PYTHON_3_11,
  // ...
  bundling: {
    buildArgs: {
      'PIPENV_VERSION': '2024.0.1',
    },
  }
};

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

It was originally hardcoded to 2022.4.8, which excluded newer features/fixes.
@github-actions github-actions bot added the beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK label Dec 19, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team December 19, 2024 14:51
@github-actions github-actions bot added the p2 label Dec 19, 2024
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@dil-emiravalles dil-emiravalles changed the title fix(lambda-python-alpha): make pipenv version a parameter for bundling chore(lambda-python-alpha): make pipenv version a parameter for bundling Dec 19, 2024
@aws-cdk-automation aws-cdk-automation dismissed their stale review December 19, 2024 14:57

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: c2c27d2
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK p2 pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants