chore(lambda-python-alpha): make pipenv version a parameter for bundling #32594
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make pipenv version a parameter in the Dockerfile for python lambda bundling. It was originally hardcoded to 2022.4.8, which excluded newer features/fixes.
Issue # (if applicable)
None.
Reason for this change
Pipenv version was originally hardcoded to 2022.4.8, which excluded newer features/fixes. And that could not be changed without providing a new Dockerfile from scratch.
Description of changes
Just made the pipenv version a new ARG in the Dockerfile. So that it can be provided from the outside.
It has the same default value as it used to have, so that the current behavior won't change.
Describe any new or updated permissions being added
None
Description of how you validated changes
Tested this same Dockerfile in my current project, providing the PIPENV_VERSION variable via CDK:
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license