-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(cli): use typed errors ToolkitError
and AuthenticationError
in CLI
#32548
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Sumu <[email protected]>
Signed-off-by: Sumu <[email protected]>
Signed-off-by: Sumu <[email protected]>
Signed-off-by: Sumu <[email protected]>
Signed-off-by: Sumu <[email protected]>
Signed-off-by: Sumu <[email protected]>
Signed-off-by: Sumu <[email protected]>
Signed-off-by: Sumu <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request
. Additionally, if clarification is needed add Clarification Request
to a comment.
Signed-off-by: Sumu <[email protected]>
…m/aws/aws-cdk into sumughan/typed-errors-cli-toolkit
Signed-off-by: Sumu <[email protected]>
ToolkitError
and AuthenticationError
in CLI ToolkitError
and AuthenticationError
in CLI
Signed-off-by: Sumu <[email protected]>
Signed-off-by: Sumu <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #32548 +/- ##
==========================================
+ Coverage 79.15% 79.26% +0.11%
==========================================
Files 107 108 +1
Lines 7139 7182 +43
Branches 1321 1324 +3
==========================================
+ Hits 5651 5693 +42
Misses 1304 1304
- Partials 184 185 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking really good! I left a few minor comments. Also happy to bypass the diff-coverage in this case - I agree with you that it's unduly for this PR. Just make sure the project coverage increases (which it currently does).
Also please configure the eslint rule for this package only to enforce we don't accidentally add new untyped errors.
Co-authored-by: Momo Kornher <[email protected]>
Co-authored-by: Momo Kornher <[email protected]>
Co-authored-by: Momo Kornher <[email protected]>
Co-authored-by: Momo Kornher <[email protected]>
Signed-off-by: Sumu <[email protected]>
…onError func on the ToolkitError class Signed-off-by: Sumu <[email protected]>
Signed-off-by: Sumu <[email protected]>
Signed-off-by: Sumu <[email protected]>
…m/aws/aws-cdk into sumughan/typed-errors-cli-toolkit
Signed-off-by: Sumu <[email protected]>
The pull request linter fails with the following errors:
PRs must pass status checks before we can provide a meaningful review. If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing ✅ A exemption request has been requested. Please wait for a maintainer's review. |
The pull request linter fails with the following errors:
PRs must pass status checks before we can provide a meaningful review. If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing ✅ A exemption request has been requested. Please wait for a maintainer's review. |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Closes #32347
This PR creates two new error types,
ToolkitError
andAuthenticationError
and uses them inaws-cdk
.Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license