Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for Ghostty #335

Merged
merged 1 commit into from
Jan 1, 2025
Merged

feat: add support for Ghostty #335

merged 1 commit into from
Jan 1, 2025

Conversation

grant0417
Copy link
Member

@grant0417 grant0417 commented Dec 30, 2024

Description of changes:
This PR adds support for Ghostty resolving #323. The changes will need to be verified in a build before release as the IME is difficult to build locally.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@grant0417 grant0417 requested a review from a team as a code owner December 30, 2024 21:16
@codecov-commenter
Copy link

codecov-commenter commented Dec 30, 2024

Codecov Report

Attention: Patch coverage is 20.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 12.34%. Comparing base (93acda9) to head (67889a7).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
crates/fig_util/src/terminal.rs 20.00% 4 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #335   +/-   ##
=======================================
  Coverage   12.34%   12.34%           
=======================================
  Files        2233     2233           
  Lines      190080   190085    +5     
  Branches   174665   174670    +5     
=======================================
+ Hits        23457    23459    +2     
- Misses     165456   165458    +2     
- Partials     1167     1168    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@grant0417 grant0417 merged commit f2e3632 into aws:main Jan 1, 2025
10 checks passed
@aryasaatvik
Copy link
Contributor

Description of changes: This PR adds support for Ghostty resolving #323. The changes will need to be verified in a build before release as the IME is difficult to build locally.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

I built it locally for mac aarch64 but yeah couldn't get IME to work :(

This was referenced Jan 7, 2025
@grant0417
Copy link
Member Author

This has been released now as part of 1.6.0

@nikolay
Copy link

nikolay commented Feb 5, 2025

This doesn't seem to work as the popup shows up in the bottom-left corner.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants