Add integration test run to test requirements in pull request template #1526
+2
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
varunch77
reviewed
Feb 3, 2025
| @@ -8,13 +8,10 @@ _How does this change address the problem?_ | |||
| By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice. | |||
|
|
|||
| # Tests | |||
| _Describe what tests you have done._ | |||
| 1. [Run integration tests](https://github.com/aws/amazon-cloudwatch-agent/actions/workflows/integration-test.yml) and provide the link. Compare it to the last revision on `main` to ensure no new tests are failing, and share that comparison here. | |||
There was a problem hiding this comment.
Our integration tests are still quite flaky—this might not be the best instruction
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue
We have up until now not required passing integration tests. Until all of our tests are passing, we need to manually validate that we are not introducing breaking changes.
Description of changes
In the pull request template, require a link to the pull request template + a test run comparison between the most recent commit on
mainand the pull request.License
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Tests
N/A.
Requirements
Before commit the code, please do the following steps.
make fmtandmake fmt-shmake lint