Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky unit test for awsentity translator logics #1420

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

zhihonl
Copy link
Contributor

@zhihonl zhihonl commented Nov 11, 2024

Description of the issue

We currently have flaky unit test for awsentity translator. This is because Golang unit test does not guarantee sequential ordering based on the order the test is written in the code, so in this case if ECS test is ran first, it will set ECS singleton's region to something valid, then when OnlyProfile unit test runs, it is still considered in ECS mode so translator will still return nil for the translation

Description of changes

  • Reset ECS singleton region variable.

License

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Tests

Unit test

Requirements

Before commit the code, please do the following steps.

  1. Run make fmt and make fmt-sh
  2. Run make lint

@zhihonl zhihonl requested a review from a team as a code owner November 11, 2024 21:36
varunch77
varunch77 previously approved these changes Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants