Fix flaky unit test for awsentity translator logics #1420
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue
We currently have flaky unit test for
awsentity
translator. This is because Golang unit test does not guarantee sequential ordering based on the order the test is written in the code, so in this case ifECS
test is ran first, it will set ECS singleton's region to something valid, then whenOnlyProfile
unit test runs, it is still considered in ECS mode so translator will still returnnil
for the translationDescription of changes
License
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Tests
Unit test
Requirements
Before commit the code, please do the following steps.
make fmt
andmake fmt-sh
make lint