-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement JMX E2E Tests in Terraform Framework #443
Open
musa-asad
wants to merge
91
commits into
main
Choose a base branch
from
e2e-jmx
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue
The CloudWatch Agent now supports JMX metrics on EKS. We need to add testing to verify the behavior for JMX metrics collection in EKS environments.
Description of changes
Co-PR: aws/amazon-cloudwatch-agent#1463.
Revision 1
test/e2e/jmx/jmx_test.go
with the following functions:ApplyHelm
: Applies a helm release based on the specifiedresources
passed in as variables, which sets up the CloudWatch Agent and deploys an annotated sample application.TestResources
: Tests to see if the appropriate resources have been deployed on the EKS cluster.TestMetrics
: Tests to see if metrics are being emitted properly based on the agent configuration file passed in.test/e2e/jmx/resources/cwagent_configs/
andtest/e2e/jmx/resources/sample_apps/
for custom agent configurations and sample applications to deploy.tomcat.sessions
andtomcat.rejected_sessions
increases above 0 accordingly.GetMetricMaximum
toutil/awsservice/cloudwatchmetrics.go
in order to find the maximum value for a metric being emitted.generator/test_case_generator.go
andgenerator/resources/eks_e2e_test_matrix.json
to be able to use this as a configurable value from the generated matrix.Revision 2
require
/assert
methods instead oft.Fatal
/t.Error
.destroy
logic for Kubernetes resources by uninstalling helm and deletingtest
namespace.--values
from Helm installation since it isn't required.kubectl wait
for operator deployment instead oftime.Sleep
to continue as soon as the operator is ready.-deployment
from deployment names due to redundancy.testXMetrics
functions due to redundancy.GetMetricMaximum
withCheckMetricAboveZero
, which exits as soon as it finds a metric above zero.ami_type
andinstance_type
to have control over those values for future testing.kafka
andkafka_producer
metrics.util/common/kubernetes.go
.jmx
in agent configuration.jmx
environmental variables in application pod.License
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Tests
View Workflow Run #12452251638