Update module1 to remove dependency on the Goerli test network #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpdornseifer
requested changes
Jun 10, 2024
tests/module1/run_e2e_pipeline.sh
Outdated
| ALCHEMY_POLICY_ID="" | ||
| ALCHEMY_API_KEY="" | ||
| NFT_STORAGE_API_TOKEN="" | ||
| RPC_ENDPOINT=https://eth-sepolia.g.alchemy.com/v2/tPlhuS4IDHbHHU7RBsZTUN9tciY4ojor |
There was a problem hiding this comment.
please clean up - maybe we should move to e2e test case parameterisation to an env based approach to avoid checked in creds
There was a problem hiding this comment.
pipeline faces missing library issue right now ("@alchemy/aa-core") fix in progress
dpdornseifer
approved these changes
Jul 1, 2024
dpdornseifer
requested changes
Jul 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: Since the Goerli test network has been deprecated this workshop stopped working properly. There were hard coded variables making it impossible to run the workshop on other test networks such as Sepolia.
Description of changes: worked on removing the hard coded dependencies and move variables to AWS Systems Manager Parameter Store. Worked on fixing some issues with the frontend not being able to query the user wallet and NFT because of hard coded URL. Updated README.md files and integration tests to reflects those changes.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.