Update DeepSpeed test case with improved documentation and scripts #867
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add --container-mount-home flag to Pyxis configuration for proper home directory mounting - Update Llama2 download documentation with latest methods (HuggingFace CLI and Meta direct download) - Consolidate finetune_llama.sbatch script to root directory with improved structure - Convert variable definitions to declare -a array style for better bash practices - Fix DATA_PATH variable definition syntax error - Update argument passing to use proper array expansion - Remove deprecated scripts from scripts/ directory - Add detailed HuggingFace CLI download instructions with authentication steps Co-authored-by: aravneelaws <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates the DeepSpeed test case with improved documentation, better script organization, and fixes for Pyxis/Enroot container configuration.
Changes
Container Configuration
--container-mount-homeflag to properly mount home directory in Pyxis containersDATA_PATHvariable definition syntax errorDocumentation Improvements
Script Improvements
finetune_llama.sbatchto root directory for better organizationdeclare -aarray style for consistency"${ARRAY[@]}")FINETUNE_ARGS,CONVERT_HF2MDS_ARGS, andCONVERT_MDS2HF_ARGSarraysCOMM_ARGSfor conversion commandsCleanup
scripts/directory:convert-weights-hf-to-megatron-deepspeed.shscripts/finetune_llama.sbatchscripts/finetune_llama.shTesting
Related Work
This PR complements the fix submitted to Megatron-DeepSpeed for the DummyOptim state_dict issue: KeitaW/Megatron-DeepSpeed#1
Co-authored-by: aravneelaws [email protected]