fix(logger): not passing persistent keys to children #4740
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks a lot for your first contribution! Please check out our contributing guidelines and don't hesitate to ask whatever you need. |
boring-cyborg
bot
added
logger
iamgerg
commented
Nov 12, 2025
svozza
reviewed
Nov 12, 2025
Contributor
|
Thank you for the quick turnaround! I only have two minor comments but other than that this looks great. |
iamgerg
force-pushed
the
iamgerg/fix-persistentKeys-for-children
branch
from
abca587 to
fec3943
Compare
pull-request-size
bot
added
size/M
svozza
reviewed
Nov 12, 2025
svozza
reviewed
Nov 12, 2025
pull-request-size
bot
added
size/L
svozza
approved these changes
Nov 12, 2025
|
Contributor
|
Really thorough job here @iamgerg, thank you! Merging now. |
|
Awesome work, congrats on your first merged pull request and thank you for helping improve everyone's experience! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes
This PR fixes the bug where
persistentKeyspassed into a parent logger would be overwritten instead of merged by any value forpersistentKeysbeing passed using thelogger.createChildmethod. See the issue linked below for more details.Issue number: closes #4719
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.