-
Notifications
You must be signed in to change notification settings - Fork 428
feat(bedrock_agent): add new Amazon Bedrock Agents Functions Resolver #6564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #6564 +/- ##
===========================================
+ Coverage 96.12% 96.14% +0.02%
===========================================
Files 253 255 +2
Lines 12104 12251 +147
Branches 902 912 +10
===========================================
+ Hits 11635 11779 +144
- Misses 369 370 +1
- Partials 100 102 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Ana Falcão <[email protected]>
…tools/powertools-lambda-python into feat/bedrock_functions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @anafalcao! I finished the first review and we need to fix the parameters part before proceeding with another review. Can you please work on that?
function_name = self.current_event.function | ||
|
||
try: | ||
result = self._tools[function_name]["function"]() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A critical part of this agent's workflow is passing parameters to functions. These parameters contain values that will be useful for the function in question. In this discussion, we talk about this:
Support for injecting parameters into the function signature.
Can you pls add this support?
|
Hey @leandrodamascena ! Thank you so much for all the feedbacks, I pushed a new commit addressing them. |
Issue number:
#6300
Summary
This PR introduces support for Bedrock Agents Functions, providing the user a similar experience from the current Bedrock Agents with OpenAPI Resolver.
Changes
User experience
Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change?
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.