-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: upgraded embedded metrics library for high resolution metrics #1550
Conversation
💾 Artifacts Size Report
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v2 #1550 +/- ##
=============================================
- Coverage 89.79% 76.91% -12.89%
- Complexity 406 466 +60
=============================================
Files 44 49 +5
Lines 1274 1685 +411
Branches 165 254 +89
=============================================
+ Hits 1144 1296 +152
- Misses 88 300 +212
- Partials 42 89 +47 ☔ View full report in Codecov by Sentry. |
|
|
Hey @jdoherty sorry for the high latency on this one! LGTM (and tests 🎸 ) Couple small things --> I think the spotbugs warning needs an ignore in the overrides file:
TBH i'm not sure why this is being picked up now. You've not touched the class itself, but the implementation of Can you also chuck some words in the docs? The python guys have a section for high-resolution metrics that might be inspirational/reusable. E2E tests are broken in |
Fixed
Done @scottgerring, you can have a quick look but we should be good with that one. |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Merci @jdoherty and @jeromevdl
**Issue 1041 **
Description of changes:
Updated emf library allowing users to publish high resolution metrics
Checklist
Breaking change checklist
RFC issue #:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Notes:
setAccessible
#1449) in another ticket