Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pull_request_template.md #830

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Update pull_request_template.md #830

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
89089a7
Update pull_request_template.md
musunita Feb 6, 2024
7a420a6
Update pull_request_template.md
musunita Feb 6, 2024
2f440aa
Update pull_request_template.md
musunita Feb 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions .github/pull_request_template.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,9 @@
Please specify the release version, instance size and type, OS type and test output.

Training tutorial:
Convergence graph for training tutorials
Performance metrics average_throughput, latency_p50, latency_p99 and MFU% if available
Please attach convergence graph for training tutorials.

Please attache performance metrics average_throughput, latency_p50, latency_p99 and MFU% if available


Please make sure this PR contains correct classification terms (Alpha, Beta, and Stable).
Expand All @@ -19,7 +20,7 @@ If possible, provide your results or a link to them for the reviewer to check yo


*Link to RTD for my changes:*
https://awsdocs-neuron-staging.readthedocs-hosted.com/en/YOUR_BRANCH_NAME/
https://awsdocs-neuron.readthedocs-hosted.com/en/YOUR_BRANCH_NAME/


*Additional context:*
Expand All @@ -33,7 +34,7 @@ https://awsdocs-neuron-staging.readthedocs-hosted.com/en/YOUR_BRANCH_NAME/
- [ ] (If applicable) I've automated a test to safegaurd my changes from regression.
- [ ] (If applicable) I've posted test collateral to prove my change was effective and not harmful.
- [ ] (If applicable) I've added someone from QA to the list of reviewers. Do this if you didn't make an automated test or feel it's appropriate for another reason.
- [ ] (If applicable) I've reviewed the licenses of updated and new binaries and their dependencies to make sure all licenses are on the pre-approved Amazon license list. See https://inside.amazon.com/en/services/legal/us/OpenSource/Pages/BlessedOpenSourceLicenses.aspx.



## Pytest Marker Checklist
Expand Down