-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove reference to owner in sns-controller to fix provisioning on multiple accounts #44
base: main
Are you sure you want to change the base?
Conversation
…g on multiple accounts The previous setup would override the value in the configmap, making it so that any reconciliation after the first creation fails if the account does not match the key used in the auth configmap.
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: jose-fully-ported The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @jose-fully-ported. Thanks for your PR. I'm waiting for a aws-controllers-k8s member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Issues go stale after 180d of inactivity. |
Stale issues rot after 60d of inactivity. |
Rotten issues close after 60d of inactivity. |
@ack-bot: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/reopen |
@a-hilaly: Reopened this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Description of changes:
The previous setup would override the value in the configmap, making it so that any reconciliation after the first creation fails if the account does not match the key used in the auth configmap.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.