Implement resource ConfigurationSet #7
Conversation
cPu1
force-pushed
the
resource/configuration-set
branch
4 times, most recently
from
21d65f9 to
34972c2
Compare
Signed-off-by: cpu1 <[email protected]>
cPu1
force-pushed
the
resource/configuration-set
branch
from
34972c2 to
b2b04ec
Compare
|
@cPu1: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
| tags: | ||
| ignore: true |
There was a problem hiding this comment.
Can you please also add tag support as well?
|
|
||
| resources: | ||
| ConfigurationSet: | ||
| fields: |
There was a problem hiding this comment.
It looks likeConfigurationSetEventDestination have a 1:1 mapping with ConfigurationSet, so it needs to be injected as a field here. We do similar things with S3::Bucket and S3::BucketPolicy (they are managed using one CRD), same with IAM:Role and IAM::RolePolicyAttachement
There was a problem hiding this comment.
And I believe we need to do the same with ReceiptRuleSpec and ReceiptRule
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: a-hilaly, cPu1 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Issue #, if available: aws-controllers-k8s/community#493
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.