Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add addoption by annotation feature #164

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

michaelhtm
Copy link
Member

Issue #, if available:

Description of changes:
These changes introduce a new feature gate called ForceAdoptResources
which allows users to provide the read required fields in the annotation and
an empty spec, and the controller would populate the resource and adopt
from AWS

Here's an example for cluster:

apiVersion: eks.services.k8s.aws/v1alpha1
kind: Cluster
metadata:
  name: my-cluster
  annotations:
    services.k8s.aws/force-adoption: "true"
    services.k8s.aws/adoption-fields: | 
        {
          "name": "my-cluster"
        }

Here's another one to adopt a nodegroup

apiVersion: eks.services.k8s.aws/v1alpha1
kind: NodeGroup
metadata:
  name: my-ng
  annotations:
    services.k8s.aws/force-adoption: "true"
    services.k8s.aws/adoption-fields: | 
        {
          "name": "ng-12324",
          "clusterName": "my-cluster"
        }

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ack-prow ack-prow bot requested review from a-hilaly and jlbutler November 14, 2024 00:13
Copy link

ack-prow bot commented Nov 14, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: michaelhtm
Once this PR has been reviewed and has the lgtm label, please assign a-hilaly for approval by writing /assign @a-hilaly in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

These changes introduce a new feature gate called `ForceAdoptResources`
which allows users to provide the read required fields in the annotation
and an empty spec, and the controller would populate the resource
and adopt from AWS
Copy link

ack-prow bot commented Nov 19, 2024

@michaelhtm: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
verify-attribution 3fd1d42 link false /test verify-attribution
ecr-controller-test 3fd1d42 link true /test ecr-controller-test
iam-controller-test 3fd1d42 link true /test iam-controller-test
s3-controller-test 3fd1d42 link true /test s3-controller-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant