Skip to content

chore: increase git fetch default timeout to 180s #607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: increase git fetch default timeout to 180s #607

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkg/sdk/repo.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ import (
const (
sdkRepoURLV2 = "https://github.com/aws/aws-sdk-go-v2"
defaultGitCloneTimeout = 180 * time.Second
defaultGitFetchTimeout = 30 * time.Second
defaultGitFetchTimeout = 180 * time.Second
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just for fetching tags right? it is hard to believe that fetching tags can take more than 30seconds, are those are just refs in the .git folder?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is..aws-sdk-go-v2 has 885 tags to be fetched...maybe moving forward we can rethink this...

)

func ContextWithSigterm(ctx context.Context) (context.Context, context.CancelFunc) {
Expand Down