Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Distribution deletion and state handling #50

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

a-hilaly
Copy link
Member

Enhance Distribution lifecycle management, focusing on deletion
process and state handling:

  1. Implement automatic disabling of Distributions before deletion
  2. Add requeuing mechanism for Distributions in 'InProgress' state
  3. Update e2e tests to test disable-pre-delete scenarios and account
    for longer Distribution deletion times

These changes prevent API errors during deletion, avoid premature operations
on in-progress Distributions, and improve overall resource management
reliability.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link

ack-prow bot commented Nov 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: a-hilaly

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-prow ack-prow bot added the approved label Nov 26, 2024
@a-hilaly a-hilaly force-pushed the distribution/disable-pre-delete branch from 9c112ab to bf0813e Compare November 26, 2024 21:20
Copy link
Member

@michaelhtm michaelhtm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job Amine 🚀🚀🚀
left one nit

return cs == StatusInProgress
}

func distributionDeployed(r *resource) bool {
Copy link
Member

@michaelhtm michaelhtm Nov 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: is this used?

@a-hilaly a-hilaly force-pushed the distribution/disable-pre-delete branch 2 times, most recently from e57ea16 to 1083b4d Compare November 27, 2024 02:30
Enhance Distribution lifecycle management, focusing on deletion
process and state handling:

1. Implement automatic disabling of Distributions before deletion
2. Add requeuing mechanism for Distributions in 'InProgress' state
3. Update e2e tests to test disable-pre-delete scenarios and account
   for longer Distribution deletion times

These changes prevent API errors during deletion, avoid premature operations
on in-progress Distributions, and improve overall resource management
reliability.
@a-hilaly a-hilaly force-pushed the distribution/disable-pre-delete branch from 1083b4d to 8d31ebc Compare November 27, 2024 04:13
Copy link

ack-prow bot commented Nov 27, 2024

@a-hilaly: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
cloudfront-verify-attribution 8d31ebc link false /test cloudfront-verify-attribution
cloudfront-kind-e2e 8d31ebc link true /test cloudfront-kind-e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants