-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Distribution
deletion and state handling
#50
base: main
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: a-hilaly The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
9c112ab
to
bf0813e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job Amine 🚀🚀🚀
left one nit
return cs == StatusInProgress | ||
} | ||
|
||
func distributionDeployed(r *resource) bool { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: is this used?
e57ea16
to
1083b4d
Compare
Enhance Distribution lifecycle management, focusing on deletion process and state handling: 1. Implement automatic disabling of Distributions before deletion 2. Add requeuing mechanism for Distributions in 'InProgress' state 3. Update e2e tests to test disable-pre-delete scenarios and account for longer Distribution deletion times These changes prevent API errors during deletion, avoid premature operations on in-progress Distributions, and improve overall resource management reliability.
1083b4d
to
8d31ebc
Compare
@a-hilaly: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Enhance
Distribution
lifecycle management, focusing on deletionprocess and state handling:
Distributions
before deletionDistributions
in 'InProgress' statefor longer Distribution deletion times
These changes prevent API errors during deletion, avoid premature operations
on in-progress Distributions, and improve overall resource management
reliability.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.