Exclude client-side network errors from schema download fault metrics #406
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Exclude client-side network errors from
getSchemas.faultmetrics inGetPublicSchemaTaskandGetSamSchemaTask. These errors are caused by user environment issues (corporate proxies, firewalls, DNS) and are outside our control.Problem
Analysis of the last 24 hours of telemetry data shows:
~54% of these failures are client-side errors we cannot fix:
Solution
Added
isClientNetworkError()utility that detects client-side network errors by matching known error patterns:self signed certificate,unable to get local issuer certificate, etc.ECONNRESET,ETIMEDOUT,ENOTFOUND,socket hang up, etc.status code 407,TOO_MANY_REDIRECTS,Parse Error: Expected HTTPWhen these errors occur, the schema tasks now return gracefully instead of throwing, so they don't count as faults in our metrics.
Testing
isClientNetworkError()inErrors.test.tsGetSchemaTask.test.tsBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.