Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing the issue when getting null field at translator, Update logProcessorEnabled into True #27

Merged
merged 1 commit into from
May 24, 2024

Conversation

houmilen
Copy link
Contributor

@houmilen houmilen commented May 24, 2024

1: Fixing the An issue when we handler an object contains null field.
2: Update logProcessorEnabled into True

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@houmilen houmilen requested a review from dmoini May 24, 2024 22:37
Copy link
Contributor

@dmoini dmoini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the future, you can clean up the PR description a bit. The changes are embedded between the headers per section. If you do not require a section (e.g. Issue #, if available:), feel free to delete it from the PR description. If you have multiple changes, uses dotted lists to detail each change so it is easier for the reviewer to understand.

@dmoini
Copy link
Contributor

dmoini commented May 24, 2024

Also, please close out #25 since this PR includes those changes.

@houmilen houmilen merged commit 050caaf into main May 24, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants