-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Flutter V2 Gen1 Docs Update #7499
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update the flutter mobile support doc. * Add file name. * Add Safe Area.
* storage: update swift storage with storage path * chore: update swift storage docs with storage path * chore: update storage getting started content * chore: add callout warning to file access level * chore: update gen2 callout * chore: convert fragments to inline filter * update storage path example * Android Gen2 Storage * remove upload from getting started * Add Using Storagepath * add content to storage path page * Expand storagepath * improve doc * update callout message * modify file access level callout * add accidental remove * gramatical issues * Update src/pages/[platform]/build-a-backend/storage/download/index.mdx Co-authored-by: Jordan Nelson <[email protected]> * Update src/pages/[platform]/build-a-backend/storage/upload/index.mdx Co-authored-by: Jordan Nelson <[email protected]> * Update src/pages/[platform]/build-a-backend/storage/storagepath/index.mdx Co-authored-by: Jordan Nelson <[email protected]> * Update src/pages/[platform]/build-a-backend/storage/list/index.mdx Co-authored-by: Jordan Nelson <[email protected]> * Update src/pages/[platform]/build-a-backend/storage/remove/index.mdx Co-authored-by: Jordan Nelson <[email protected]> * Bump Android version --------- Co-authored-by: Tuan Pham <[email protected]> Co-authored-by: Jordan Nelson <[email protected]>
…7023) * chore: add kotlin update to docs and formatting changes for new flutter build.gradle creation * chore: remove steps for apps created with flutter 3.16 and earlier
Co-authored-by: Muhammed Salih Guler <[email protected]>
* chore: remove v0 flutter fragment * chore: remove move flutter fragment * chore: remove the move page from the directory and remove move from pages completely
* chore: fix broken links by adding inline filters * chore: remove the line instead of use InlineFilter since flutter is the only platform with this page * chore: remove getting started link under storage subheading that was being used as a placeholder
khatruong2009
requested review from
a team,
ykethan,
Jay2113,
chrisbonifacio,
aspittel,
renebrandel,
swaminator,
dbanksdesign,
josefaidt and
ErikCH
as code owners
May 6, 2024 17:21
hdworld11
previously approved these changes
May 20, 2024
renebrandel
previously approved these changes
May 20, 2024
Jordan-Nelson
previously approved these changes
May 20, 2024
jacoblogan
reviewed
May 20, 2024
@@ -1256,9 +1256,6 @@ export const directory = { | |||
{ | |||
path: 'src/pages/gen1/[platform]/build-a-backend/storage/copy/index.mdx' | |||
}, | |||
{ | |||
path: 'src/pages/gen1/[platform]/build-a-backend/storage/move/index.mdx' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please coordinate with @katiegoines to get a redirect in place for this page.
jacoblogan
previously approved these changes
May 20, 2024
khatruong2009
dismissed stale reviews from jacoblogan, Jordan-Nelson, and renebrandel
via
May 20, 2024 20:27
bd2f456
Jordan-Nelson
previously approved these changes
May 20, 2024
renebrandel
approved these changes
May 20, 2024
jacoblogan
approved these changes
May 20, 2024
Jordan-Nelson
approved these changes
May 21, 2024
hdworld11
approved these changes
May 21, 2024
aspittel
approved these changes
May 21, 2024
josefaidt
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Related GitHub issue #, if available:
Instructions
If this PR should not be merged upon approval for any reason, please submit as a DRAFT
Which product(s) are affected by this PR (if applicable)?
Which platform(s) are affected by this PR (if applicable)?
Please add the product(s)/platform(s) affected to the PR title
Checks
Does this PR conform to the styleguide?
Does this PR include filetypes other than markdown or images? Please add or update unit tests accordingly.
Are any files being deleted with this PR? If so, have the needed redirects been created?
Are all links in MDX files using the MDX link syntax rather than HTML link syntax?
ref: MDX:
[link](https://docs.amplify.aws/)
HTML:
<a href="https://docs.amplify.aws/">link</a>
When this PR is ready to merge, please check the box below
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.