Generate sitemap with only canonical urls #7131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
jacoblogan
reviewed
Apr 25, 2024
| console.log(`${path} doesn't exist`); | ||
| return formatDate(new Date()); | ||
| }; | ||
| const PLATFORMS = [ |
There was a problem hiding this comment.
can we reuse the platform const from https://github.com/aws-amplify/docs/blob/main/src/data/platforms.ts
There was a problem hiding this comment.
When I tried to do that originally, it kept throwing an error saying it couldn't find the module @data/platforms. I also tried specifying the relative path ../src/data/platforms.js but that didn't work either. Maybe I'm doing something wrong though? Do you have any thoughts on what I tried so far?
There was a problem hiding this comment.
I wonder if it's because platforms.ts is a typescript file and it needs to be a complied js file? 🤔
hbuchel
approved these changes
Apr 29, 2024
katiegoines
approved these changes
Apr 29, 2024
jacoblogan
approved these changes
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
cheerioto help parse HTML build filesmainelements in each of the HTML files. After comparing them, we group the duplicate pages and select one to be the canonical url based on its platform ranking. We use this selected url in the sitemap to denote that it is a canonical url.sitemap built from this branch: https://canonical-sitemap.d1ywzrxfkb9wgg.amplifyapp.com/sitemap.xml
Staging site: https://canonical-sitemap.d1ywzrxfkb9wgg.amplifyapp.com/
Related GitHub issue #, if available:
Instructions
If this PR should not be merged upon approval for any reason, please submit as a DRAFT
Which product(s) are affected by this PR (if applicable)?
Which platform(s) are affected by this PR (if applicable)?
Please add the product(s)/platform(s) affected to the PR title
Checks
Does this PR conform to the styleguide?
Does this PR include filetypes other than markdown or images? Please add or update unit tests accordingly.
Are any files being deleted with this PR? If so, have the needed redirects been created?
Are all links in MDX files using the MDX link syntax rather than HTML link syntax?
ref: MDX:
[link](https://docs.amplify.aws/)HTML:
<a href="https://docs.amplify.aws/">link</a>When this PR is ready to merge, please check the box below
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.