Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rn version switcher #6278

Merged
merged 9 commits into from
Nov 10, 2023
Merged

Rn version switcher #6278

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
f230a45
add version switcher to web frameworks
Nov 9, 2023
495f191
update styling for longer react-native title
Nov 9, 2023
059faf0
Merge branch 'next-release/main' into rn-version-switcher
jacoblogan Nov 9, 2023
df0d715
small css tweaks
hbuchel Nov 9, 2023
413361a
Merge pull request #6281 from aws-amplify/PlatformVersionSwitcherTweaks
jacoblogan Nov 9, 2023
9ff1834
Merge branch 'next-release/main' into rn-version-switcher
timngyn Nov 9, 2023
933c768
Merge branch 'next-release/main' into rn-version-switcher
jacoblogan Nov 10, 2023
c88c1d4
Merge branch 'next-release/main' into rn-version-switcher
jacoblogan Nov 10, 2023
c6558a4
Merge branch 'next-release/main' into rn-version-switcher
jacoblogan Nov 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/PlatformNavigator/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ export function PlatformNavigator({ currentPlatform, isPrev }) {
flex="1 1 0"
paddingRight="xs"
>
<Flex as="span" alignItems="center" gap="small">
<Flex as="span" alignItems="center" gap="xs">
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

React Native looked very cramped trying to buy just a little more space

{platformItem.icon}
{platformTitle}
</Flex>
Expand Down
22 changes: 21 additions & 1 deletion src/data/platforms.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,27 @@ export const PLATFORM_VERSIONS = {
'javascript': {
prev: 'v5',
current: 'v6'
}
},
'react-native': {
prev: 'v5',
current: 'v6'
},
'react': {
prev: 'v5',
current: 'v6'
},
'angular': {
prev: 'v5',
current: 'v6'
},
'vue': {
prev: 'v5',
current: 'v6'
},
'nextjs': {
prev: 'v5',
current: 'v6'
},
}

export const DEFAULT_PLATFORM: Platform = 'javascript';
2 changes: 2 additions & 0 deletions src/styles/platform-navigator.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@
&__button {
display: flex;
justify-content: space-between;
white-space: nowrap;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

React Native title was wrapping

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering if we should just decrease the font size or maybe make the arrow smaller? It still looks really cramped:

image

padding-inline-start: var(--amplify-space-xs)
}

.popover {
Expand Down
Loading