Cli legacy alert #6277
Merged
Cli legacy alert #6277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timngyn
commented
Nov 9, 2023
There was a problem hiding this comment.
Not sure if we had something like this already, if I missed it then let me know and I can remove this file
timngyn
force-pushed
the
cli-legacy-alert
branch
4 times, most recently
from
37791e7 to
8e76d24
Compare
reesscot
reviewed
Nov 9, 2023
| export function useCurrentPlatform() { | ||
| const router = useRouter(); | ||
|
|
||
| return router.query.platform as Platform; |
There was a problem hiding this comment.
Jacob confirmed this should work in Next.js's SSG mode
There was a problem hiding this comment.
yeah this is working with ssg, I'm seeing the link being generated correctly
hbuchel
approved these changes
Nov 9, 2023
timngyn
force-pushed
the
cli-legacy-alert
branch
from
8e76d24 to
628e812
Compare
reesscot
approved these changes
Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Staging site: https://cli-legacy-alert.d1ywzrxfkb9wgg.amplifyapp.com/
Example links:
Related GitHub issue #, if available:
Instructions
If this PR should not be merged upon approval for any reason, please submit as a DRAFT
Which product(s) are affected by this PR (if applicable)?
Which platform(s) are affected by this PR (if applicable)?
Please add the product(s)/platform(s) affected to the PR title
Checks
Does this PR conform to the styleguide?
Does this PR include filetypes other than markdown or images? Please add or update unit tests accordingly.
Are any files being deleted with this PR? If so, have the needed redirects been created?
Are all links in MDX files using the MDX link syntax rather than HTML link syntax?
ref: MDX:
[link](https://link.com)HTML:
<a href="https://link.com">link</a>When this PR is ready to merge, please check the box below
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.