fix: relative url error related to console errors #6228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hbuchel
reviewed
Nov 8, 2023
There was a problem hiding this comment.
Did you check other pages that are using this component to see if this change breaks those links? Looking at the failed link checker test on this PR I'm wondering if the path passed to InternalLink needs to be updated and not the component itself. Can you please verify that?
reesscot
suggested changes
Nov 8, 2023
sowmya-kota07
force-pushed
the
Internal-links
branch
5 times, most recently
from
cb36c30 to
0b5ca98
Compare
jacoblogan
reviewed
Nov 10, 2023
| if (hrefParts[0].endsWith('/')) { | ||
| href = `${hrefParts[0]}q/${filterKind}/${filterKey}#${hrefParts[1]}`; | ||
| } else { | ||
| href = `${hrefParts[0]}/q/${filterKind}/${filterKey}/${hrefParts[1]}`; |
There was a problem hiding this comment.
missing # on this line ${hrefParts[0]}/q/${filterKind}/${filterKey}#${hrefParts[1]}
sowmya-kota07
force-pushed
the
Internal-links
branch
from
77c37f2 to
b2ac604
Compare
|
Ran the console error script locally against this change and all of the // errors have been resolved |
jacoblogan
approved these changes
Nov 10, 2023
hbuchel
approved these changes
Nov 10, 2023
reesscot
approved these changes
Nov 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Fix
Console Errors: https://github.com/aws-amplify/docs/actions/runs/6580015445/job/17877101477?pr=5966Staging site: https://internal-links.d1ywzrxfkb9wgg.amplifyapp.com/
Errors Reasonsurls like this will produce a double slash /lib/datastore/setup-auth-rules/ this also includes urls with a slash and hash /lib/datastore/setup-auth-rules/#something an example of this can be found on page http://localhost:3000/lib/datastore/sync/q/platform/android/ and the link for this is in src/fragments/lib/datastore/android/sync/50-selectiveSync.mdx
This will resolve the error
Invalid href '/lib-v1/datastore/setup-auth-rules//q/platform/android#configure-multiple-authorization-types' passed to next/router in page: '/lib-v1/graphqlapi/authz/q/platform/[platform]'. Repeated forward-slashes (//) or backslashes \ are not valid in the href. found on http://localhost:3000/lib-v1/graphqlapi/authz/q/platform/android/
Related GitHub issue #, if available:
Instructions
If this PR should not be merged upon approval for any reason, please submit as a DRAFT
Which product(s) are affected by this PR (if applicable)?
Which platform(s) are affected by this PR (if applicable)?
Please add the product(s)/platform(s) affected to the PR title
Checks
Does this PR conform to the styleguide?
Does this PR include filetypes other than markdown or images? Please add or update unit tests accordingly.
Are any files being deleted with this PR? If so, have the needed redirects been created?
Are all links in MDX files using the MDX link syntax rather than HTML link syntax?
ref: MDX:
[link](https://link.com)HTML:
<a href="https://link.com">link</a>When this PR is ready to merge, please check the box below
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.